Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update permissions #1049

Merged
merged 2 commits into from
Sep 2, 2021
Merged

fix: Update permissions #1049

merged 2 commits into from
Sep 2, 2021

Conversation

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1049 (3a7c8ce) into 7.34.x (27f5a57) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           7.34.x    #1049   +/-   ##
=======================================
  Coverage   50.06%   50.06%           
=======================================
  Files          56       56           
  Lines        6813     6813           
=======================================
  Hits         3411     3411           
  Misses       3036     3036           
  Partials      366      366           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f5a57...3a7c8ce. Read the comment docs.

@@ -689,19 +700,19 @@ spec:
- get
- patch
- update
- apiGroups:
- extensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may be still needed for DWCO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, sleshchenko, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit bba8c53 into 7.34.x Sep 2, 2021
@tolusha tolusha deleted the backportpermissinos branch September 2, 2021 08:41
@che-bot che-bot added this to the 7.34 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants