-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update permissions #1049
fix: Update permissions #1049
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Codecov Report
@@ Coverage Diff @@
## 7.34.x #1049 +/- ##
=======================================
Coverage 50.06% 50.06%
=======================================
Files 56 56
Lines 6813 6813
=======================================
Hits 3411 3411
Misses 3036 3036
Partials 366 366 Continue to review full report at Codecov.
|
@@ -689,19 +700,19 @@ spec: | |||
- get | |||
- patch | |||
- update | |||
- apiGroups: | |||
- extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be still needed for DWCO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, sleshchenko, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Update rbac
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-2167
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.