Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read trusted CA configmaps only from installation namespace #1125

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Oct 6, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Limits searching namespace for trusted CA configmaps to only Che installation namespace

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20564

How to test this PR?

  1. Deploy Eclipse Che
  2. Create two configmaps with trusted CA certs: one in the installation namespace, he other one in another namespace
  3. Check, that only CA certs from the first configmap is applied.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@mmorhun mmorhun self-assigned this Oct 6, 2021
@mmorhun mmorhun changed the title Read trusted CA configmaps only from installation namespace fix: Read trusted CA configmaps only from installation namespace Oct 6, 2021
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun changed the title fix: Read trusted CA configmaps only from installation namespace Read trusted CA configmaps only from installation namespace Oct 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun merged commit 3cab035 into main Oct 6, 2021
@mmorhun mmorhun deleted the che-20564 branch October 6, 2021 09:49
@che-bot che-bot added this to the 7.38 milestone Oct 6, 2021
@tolusha tolusha mentioned this pull request Oct 6, 2021
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants