Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import ca-bundle even if there are several checluster CR (non all… #1135

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 8, 2021

…-namespace mode)

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

che-operator must add ca-bundles into eclipse-che even if there are several checluster instances.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-2358

How to test this PR?

  1. Deploy eclipse-che
chectl server:deploy \
     --installer operator \
     --platform minikube \
     --che-operator-image abazko/operator:crw-2356
  1. Create checluster CR in a default namespace
  kubectl apply -f - <<EOF
apiVersion: org.eclipse.che/v1
kind: CheCluster
metadata:
  name: eclipse-che
  namespace: default
EOF
  1. Create configmap in ecipse-che namespace
  kubectl apply -f - <<EOF
kind: ConfigMap
apiVersion: v1
metadata:
  name: test
  namespace: eclipse-che
  labels:
    app.kubernetes.io/component: ca-bundle
    app.kubernetes.io/part-of: che.eclipse.org
  annotations:
data:
  ca.crt: '<some-data>'
EOF
  1. wait che-operator finishes reconciliation
  2. check ca-certs-merged configmap for added certificates
    oc get configmap ca-certs-merged -n eclipse-che -o json | jq -r '.data'

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…-namespace mode)

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2021
@mmorhun mmorhun assigned tolusha and unassigned mmorhun Oct 8, 2021
@tolusha
Copy link
Contributor Author

tolusha commented Oct 8, 2021

/retest

@tolusha
Copy link
Contributor Author

tolusha commented Oct 8, 2021

/test v8-che-behind-proxy

@tolusha
Copy link
Contributor Author

tolusha commented Oct 8, 2021

/retest

1 similar comment
@tolusha
Copy link
Contributor Author

tolusha commented Oct 8, 2021

/retest

@tolusha
Copy link
Contributor Author

tolusha commented Oct 8, 2021

/test v8-che-behind-proxy

@tolusha
Copy link
Contributor Author

tolusha commented Oct 8, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-che-behind-proxy f8c396d link true /test v8-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit d44546b into main Oct 9, 2021
@tolusha tolusha deleted the CRW-2358 branch October 9, 2021 06:27
@che-bot che-bot added this to the 7.38 milestone Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants