Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Print 'More than one checluster Custom Resource found' warning o… #1140

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 13, 2021

…nly there are more than 1 CR

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Fix bugs when warning is printed when there are no CR at all on the cluster.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20628

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…nly there are more than 1 CR

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2021

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-devworkspace-happy-path f90d4ea link true /test v7-devworkspace-happy-path
ci/prow/v8-che-behind-proxy f90d4ea link true /test v8-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, l0rd, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 434db64 into main Oct 13, 2021
@tolusha tolusha deleted the 20628 branch October 13, 2021 09:47
@che-bot che-bot added this to the 7.38 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants