Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helmcharts to deploy Eclipse Che #1184

Merged
merged 4 commits into from
Nov 26, 2021
Merged

feat: helmcharts to deploy Eclipse Che #1184

merged 4 commits into from
Nov 26, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 19, 2021

#

apiVersion: v1
description: A Helm chart for deploying Eclipse Che to Kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: A Helm chart for deploying Eclipse Che to Kubernetes
description: A Helm chart for deploying Eclipse Che on a Kubernetes


### Helm Chart Install

Create a Namespace and install the helm chart for Eclipse Che.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Create a Namespace and install the helm chart for Eclipse Che.
Create a Namespace and install the helm chart for Eclipse Che Operator.


### Helm Versions

Helm charts are only tested with Helm version 3.7.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try and detect minimal version and put something like 3.x.y+ here.

- [Charts](#charts)
- [Kubernetes Versions](#kubernetes-versions)
- [Helm Versions](#helm-versions)
- [Helm Chart Install](#helm-chart-install)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm Chart Installation or Install the Helm Chart


- [Charts](#charts)
- [Kubernetes Versions](#kubernetes-versions)
- [Helm Versions](#helm-versions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required Helm version?

# Eclipse Che Helm Charts

- [Charts](#charts)
- [Kubernetes Versions](#kubernetes-versions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required Kubernetes version?

@@ -0,0 +1,33 @@
# Eclipse Che Helm Charts

- [Charts](#charts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me none of the headlines was clear. Maybe we should have:
Title
- Prerequisites (K8s & Helm versions)
- Installation

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Nov 25, 2021

@mmorhun
Fixed

@tolusha
Copy link
Contributor Author

tolusha commented Nov 25, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2021

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-devworkspace-happy-path 5afaeac link true /test v7-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Nov 26, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun assigned tolusha and unassigned AndrienkoAleksandr and mmorhun Nov 26, 2021
@tolusha tolusha merged commit 20ffca1 into main Nov 26, 2021
@tolusha tolusha deleted the helmcharts branch November 26, 2021 07:09
@che-bot che-bot added this to the 7.40 milestone Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants