Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace templates from Helm chart. Fix Helm chart README.md files. #1219

Merged

Conversation

AndrienkoAleksandr
Copy link
Contributor

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

What does this PR do?

Remove namespace templates from Helm chart. We do that to prevent fail Helm, when we're installing Che to the pre-created namespace. Fix Helm chart README.md files.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20552

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Dec 3, 2021
@tolusha tolusha mentioned this pull request Dec 3, 2021
28 tasks
@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2021

@AndrienkoAleksandr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-stable-to-nightly 1ca9d5e link true /test v9-stable-to-nightly
ci/prow/v9-devworkspace-happy-path 1ca9d5e link true /test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AndrienkoAleksandr AndrienkoAleksandr merged commit f45a6e0 into eclipse-che:main Dec 4, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the main-remote branch December 4, 2021 09:02
@che-bot che-bot added this to the 7.41 milestone Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants