Add environment variable for JGroups labels #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
davidfestal
approved these changes
Nov 20, 2019
|
Merging since we tested it together with @mshaposhnik on the QE cluster |
davidfestal
pushed a commit
that referenced
this pull request
Nov 21, 2019
davidfestal
added a commit
that referenced
this pull request
Nov 21, 2019
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JGroups is using labels to detect pods where replication should be enabled (to avoid pinging all containers in deployment). Since CRW using different value for
appandcomponentlabels, they should be set via environment variable.