Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to Traefik v2.8.1. Mostly just seeing if the pr checks pass. #1450

Merged
merged 5 commits into from Jul 26, 2022

Conversation

SDawley
Copy link
Contributor

@SDawley SDawley commented Jul 21, 2022

What does this PR do?

Checking to see how disruptive v2.8.1 would be.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-3136

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2022

Hi @SDawley. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1450 (fdab952) into main (47a9998) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1450   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files          74       74           
  Lines        6286     6286           
=======================================
  Hits         3798     3798           
  Misses       2118     2118           
  Partials      370      370           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tolusha
Copy link
Contributor

tolusha commented Jul 22, 2022

Hello @SDawley
Thank you for contribution.

Pls revert changes in

  • helmcharts/stable/templates/che-operator.Deployment.yaml
  • api/v2/zz_generated.deepcopy.go
  • api/v1/zz_generated.deepcopy.go

Pls sign ECA https://accounts.eclipse.org/legal/eca/validation/113504

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SDawley, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit c00dd0d into eclipse-che:main Jul 26, 2022
@che-bot che-bot added this to the 7.51 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants