Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update memory for Plugin-Registry to 1536Mi #1464

Merged
merged 2 commits into from Aug 1, 2022

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Aug 1, 2022

What does this PR do?

When OpenVSX will be included in the plug-in registry
It'll require more memory to start.
With 1536Mi I didn't received Heap space/OOM/killed process

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20549

How to test this PR?

Deploy che and check more memory is assigned for plug-in registry container

Also you can check with the OpenVSX/plug-in registry instance
with the following patch

cat EOF << > /tmp/patch.yaml
spec:
  components:
    pluginRegistry:
      deployment:
        containers:
          - image: 'quay.io/fbenoit/che-plugin-registry:openvsx-20220729'
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Change-Id: I125f1cbb5f6974f23d3b1942c3581f6a8d986046
Signed-off-by: Florent Benoit fbenoit@redhat.com

Change-Id: I125f1cbb5f6974f23d3b1942c3581f6a8d986046
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Aug 1, 2022

pls, revert changes in */stable/* files

Change-Id: I868123dae7577366295b7d9534c7347118a0421a
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
Copy link
Contributor Author

benoitf commented Aug 1, 2022

@tolusha updated

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1464 (081d043) into main (152c821) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   60.36%   60.36%           
=======================================
  Files          74       74           
  Lines        6275     6275           
=======================================
  Hits         3788     3788           
  Misses       2119     2119           
  Partials      368      368           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@benoitf benoitf merged commit bd58831 into eclipse-che:main Aug 1, 2022
@benoitf benoitf deleted the CHE-20549b branch August 1, 2022 13:40
@che-bot che-bot added this to the 7.52 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants