Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase default memory limit for embedded openvsx registry #1534

Merged
merged 1 commit into from Oct 11, 2022

Conversation

svor
Copy link
Contributor

@svor svor commented Oct 6, 2022

Signed-off-by: Valerii Svydenko vsvydenk@redhat.com

What does this PR do?

Since in DevSpaces we use another image to run the Plugin registry and openvsx is initializing at runtime, it's not enough 2Gi to start the pod. To fix the problem i want to increase the default memory limit for embedded openvsx registry to 4Gi.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-3295

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

… 4Gi

Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

@svor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-devworkspace-happy-path 9562139 link true /test v11-devworkspace-happy-path
ci/prow/v11-che-behind-proxy 9562139 link true /test v11-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @tolusha is +1, then I am too.

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, svor, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt
Copy link
Contributor

Please backport this to the 7.54.x branch, assuming we still plan to align DS 3.3 to 7.54.x

@svor svor merged commit 8e631f5 into main Oct 11, 2022
@svor svor deleted the sv-pluginReg-embedded-mem-limit branch October 11, 2022 07:58
svor added a commit that referenced this pull request Oct 11, 2022
… 4Gi (#1534)

Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>

Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
@che-bot che-bot added this to the 7.55 milestone Oct 11, 2022
svor added a commit that referenced this pull request Oct 11, 2022
… 4Gi (#1534) (#1537)

Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants