Cherry-pick PR-1687 to 7.67.x branch #1688
Conversation
amisevsk
requested review from
nickboldt,
tolusha,
AndrienkoAleksandr and
flacatus
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, ibuziuk, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update devworkspace-operator dependency version to v0.21.0
Update devworkspace-operator dependency to v0.21.0 and update vendor dir
* Add project clone container config field to CheCluster CR
Add field .spec.devEnvironments.projectCloneContainer to allow
configuring image, env, resources, and pull policy for the project clone
container.
This change reuses the existing Container struct for storing this
config, which means that
* The name field is ignored (it appears to be a discriminator for the
Deployment struct's containers[] field
* Defaults are handled differently:
* Default imagePullPolicy is the general pull policy for DWO, with
default value "Always" (instead of depending on tag as documented)
* Resource requirements set to "0" are interpreted as "do not set this
field"
* Add reconcile step that syncs CheCluster project clone to DevWorkspace
Sync the field CheCluster.devEnvironments.projectCloneConfig to the
DevWorkspaceOperatorConfig owned by the operator.
Update tests to cover new functionality.
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
cherry-pick-1687-7.67.x
branch
from
923b19c
to
c16723d
Compare
|
New changes are detected. LGTM label has been removed. |
|
Pushed changes coming from original PR review: #1687 (comment) |
|
Build 3.7 :: operator_3.7/3: Console, Changes, Git Data |
|
Build 3.7 :: sync-to-downstream_3.7/31: Console, Changes, Git Data |
|
Build 3.7 :: get-sources-rhpkg-container-build_3.7/33: devspaces-operator : 3.7 :: Build 52987232 : quay.io/devspaces/devspaces-rhel8-operator:3.7-25 |
|
Build 3.7 :: operator_3.7/4: Console, Changes, Git Data |
|
Build 3.7 :: sync-to-downstream_3.7/32: Console, Changes, Git Data |
|
Build 3.7 :: get-sources-rhpkg-container-build_3.7/34: devspaces-operator : 3.7 :: Build 52988348 : quay.io/devspaces/devspaces-rhel8-operator:3.7-26 |
|
Build 3.7 :: operator-bundle_3.7/9: Console, Changes, Git Data |
|
Build 3.7 :: sync-to-downstream_3.7/33: Console, Changes, Git Data |
What does this PR do?
Cherry-pick PR #1687 to the 7.67.x branch
Screenshot/screencast of this PR
See original PR
What issues does this PR fix or reference?
Fixes project-clone component of eclipse-che/che#22036 / https://issues.redhat.com/browse/CRW-4070 in 7.67.x branch
How to test this PR?
See original PR
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.