Respect openshift cluster wide proxy #272
Conversation
tolusha
force-pushed
the
certs
branch
2 times, most recently
from
5127622
to
dff4266
Compare
pkg/deploy/configmap_che.go
Outdated
| cheWorkspaceNoProxy := proxy.NoProxy | ||
| if proxy.HttpProxy != "" { | ||
| if proxy.NoProxy == "" { | ||
| cheWorkspaceNoProxy = os.Getenv("KUBERNETES_SERVICE_HOST") |
There was a problem hiding this comment.
I'm not 100% sure if the external K8S API URL is by default in the cluster-wide proxy settings, but I don't think so.
And in a number of cases it is required to add it in the non-proxy hosts, to allow the Keycloak server to contact the OpenShift ApiServer through this external URL that is configured in Keycloak for the openshift-v4 provider in case OpenShift OAuth in enabled.
This external URL is already retrieved by the operator by this function to configure Keycloak with Openshift OAuth. So it could be added by default here since it is usually required in typical proxy-based installations.
Of course maybe a boolean field to disable this automatic addition of the external API host in the noproxy field could certainly be useful.
|
Latest version of Eclipse installed and tested successfully on minikube. |
2 similar comments
|
Latest version of Eclipse installed and tested successfully on minikube. |
|
Latest version of Eclipse installed and tested successfully on minikube. |
|
If the intent is to include this fix in CRW 2.2, please let me know by the end of the day 06-24, and provide a PR against the 7.14.x branch. |
|
Slip to 2.3. Will this be merged in time for 7.16? I could merge it now but pr check failing :D |
|
@nickboldt |
I assume you mean "never merge if tests are failing". If so, no problem! |
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
|
Latest version of Eclipse Che installed and tested successfully on minikube. |
|
PR to update CRD doc |
Signed-off-by: Anatoliy Bazko abazko@redhat.com
Reference issues
https://issues.redhat.com/browse/CRW-732
What does this PR do
Tested on OpenShift with proxy configured. Workspace was successfully created and project was cloned.