Set sslRequired=NONE by updating DB #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
tolusha
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
AndrienkoAleksandr
approved these changes
May 29, 2020
davidfestal
approved these changes
May 29, 2020
| @@ -67,7 +67,7 @@ func GetKeycloakProvisionCommand(cr *orgv1.CheCluster, cheHost string) (command | |||
| "$realmDisplayName", realmDisplayName, | |||
| "$keycloakClientId", keycloakClientId, | |||
| "$keycloakTheme", keycloakTheme, | |||
| "$cheHost", cheHost, | |||
There was a problem hiding this comment.
Could it be that it was passed as an argument because at the point in time, the status was still not updated with the last changes (http to https for example) ?
Maybe a dumb question, but still asking ;-)
There was a problem hiding this comment.
I don't think so.
Previously it was
cheHost := instance.Spec.Server.CheHost
keycloakProvisionCommand := deploy.GetKeycloakProvisionCommand(instance, cheHost)
I think it is just some leftovers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
https://issues.redhat.com/browse/CRW-765
What does this PR do
Set
ssl_requiredtoNONEfor master realm using db query instead of admin scripts.Restarts keycloak pod to reload keycloak