Implement autodetetion for self-signed certificate flag #301
Conversation
mmorhun
requested review from
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
mmorhun
changed the title
|
Latest version of Eclipse installed and tested successfully on minikube. |
deploy/crds/org_v1_che_crd.yaml
Outdated
| required when activating the `tlsSupport` field on demo OpenShift | ||
| clusters that have not been setup with a valid certificate for | ||
| the routes. This is disabled by default. | ||
| description: Obsolete. The value of this flag is ignored. Che operator |
There was a problem hiding this comment.
Make changes in che_types and update olm files
| return nil, err | ||
| } | ||
|
|
||
| for i := range peerCertificates { |
There was a problem hiding this comment.
You can avoid using index of element and simple get element from range: for _, peerCertificate := range peerCertificates {
|
Latest version of Eclipse installed and tested successfully on minikube. |
2 similar comments
|
Latest version of Eclipse installed and tested successfully on minikube. |
|
Latest version of Eclipse installed and tested successfully on minikube. |
|
will this fix be backported to the 7.14.x branch? Seems like a great UX improvement for CRW 2.2 too |
|
Latest version of Eclipse installed and tested successfully on minikube. |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
|
Latest version of Eclipse installed and tested successfully on minikube. |
|
Rebased and updated OLM files |
Implement autodecetion for self-signed certificate flag Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What this PR does
Deprecates
selfSignedCertoption. CR value is present, but actually has no effect.In case of Kubernetes,
self-signed-certificatesecret is checked for presence. If it exists, then it will be propagated to Che components. Also, if no secrets are precreated, they will be generated and treated as self-signed.In case of Openshift, router certificate is examined for self-signed certificate presence. If so, then
self-signed-certificatesecret will be created and propagated to Che trust store. Otherwise, it is considered that commonly trusted certificate is used.Related issues:
eclipse-che/che#16764
Tests
Tested on: