Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use architecture dependent images #398

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Use architecture dependent images #398

merged 2 commits into from
Aug 10, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 7, 2020

Signed-off-by: Anatolii Bazko abazko@redhat.com

Reference issue

https://issues.redhat.com/browse/CRW-1131

What does this PR do

Using architecture dependent images.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Aug 7, 2020

/test v5-che-operator-olm-latest-changes-tests

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we only need the keycloak (RH-SSO) image to be named differently by arch, but this solution should work for ANY images we have to use in future which are openjdk/openj9 differentiated, even plugin & devfile registries, which right now are planned to be built with different references inside them, rather than being differently-named images.

Thus quay.io/crw/pluginregistry-rhel8:2.4 will have:

  • for x, references to EAP and XP images w/ openjdk
  • for z & p, references to EAP and XP images with openj9
    (but the published containers will all have the same name/tag in OSBS/RHCC/Quay)

So... +1, as this should unblock us from moving to the bundle format for operator-metadata and enable x/z/p arches too.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, tolusha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt
Copy link
Contributor

Once this is merged for Che 7.18, the followup work for CRW 2.4 would be to:

  • insert RELATED_IMAGE_keycloak_s390x = SSO for Z image
  • insert RELATED_IMAGE_keycloak_ppc64le = SSO for Power image

into the csv for CRW 2.4.

Correct?

@flacatus
Copy link
Contributor

flacatus commented Aug 7, 2020

/retest

@tolusha
Copy link
Contributor Author

tolusha commented Aug 10, 2020

@nickboldt
Correct

@tolusha tolusha merged commit 68764c8 into master Aug 10, 2020
@tolusha tolusha deleted the archimages branch August 10, 2020 06:01
@che-bot che-bot added this to the 7.18 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants