Do not use proxy settings for test route while getting cluster CA certificate #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tificate Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
requested review from
l0rd,
davidfestal,
tolusha,
AndrienkoAleksandr and
flacatus
42 tasks
tolusha
approved these changes
Aug 18, 2020
AndrienkoAleksandr
approved these changes
Aug 18, 2020
flacatus
approved these changes
Aug 19, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, flacatus, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do
We use test route to retrieve cluster CA certificate. However, in case of using proxy, it might change the packets routing which may cause retrieving another certificate. This PR aims to fix such problem. (This behaviour was faced with a proxy with SSL Bump enabled. Then we get proxy certificate instead of Openshift one).
Related issues
eclipse-che/che#17552