Add server TLS key and cert into Che configmap if a separate namespace for Che workspaces is configured #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorhun
requested review from
davidfestal,
tolusha,
AndrienkoAleksandr and
flacatus
58 tasks
|
Please rebase with master changes; there some changes passing arguments to functions after merging: #420 |
tolusha
reviewed
Aug 31, 2020
tolusha
approved these changes
Aug 31, 2020
…e for Che workspaces is configured Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
AndrienkoAleksandr
approved these changes
Aug 31, 2020
flacatus
approved these changes
Aug 31, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, flacatus, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do
If Eclipse Che is configured to use a separate namespace for Che workspaces via
CHE_INFRA_KUBERNETES_NAMESPACE_DEFAULTChe property, then add into Che config map Che server TLS secret (key and certificate) in order for Che server to be able to configure workspace components with right TLS key and certificate (as it is not possible to access Che server TLS secret from a separate namespace) .Which issues this PR resolves
eclipse-che/che#17631