Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate server:start command #486

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Deprecate server:start command #486

merged 2 commits into from
Oct 19, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 7, 2020 •
edited
Loading

Signed-off-by: Anatolii Bazko abazko@redhat.com

Reference issue

eclipse-che/che#18057

@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tolusha tolusha mentioned this pull request Oct 7, 2020
Closed
50 tasks
@tolusha
Deprecate server:start command
973f34d 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Deprecate server:start
9c99010 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha marked this pull request as ready for review October 19, 2020 06:47
@openshift-merge-robot
Copy link

@tolusha: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4-che-operator-update 9c99010 link /test v4-che-operator-update
ci/prow/v3-che-operator-update 9c99010 link /test v3-che-operator-update
ci/prow/v5-che-operator-update 9c99010 link /test v5-che-operator-update
ci/prow/v5-che-operator-olm-latest-changes-tests 9c99010 link /test v5-che-operator-olm-latest-changes-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 265fd73 into master Oct 19, 2020
@tolusha tolusha deleted the deprecateserverstart branch October 19, 2020 10:38
@nickboldt
Copy link
Contributor

Are we also adding a new server:start command to match the server:stop one?

nickboldt pushed a commit to nickboldt/che-operator that referenced this pull request Oct 20, 2020
@tolusha @nickboldt
Deprecate server:start command (eclipse-che#486)
d9bfbcc 
* Deprecate server:start command

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@nickboldt nickboldt mentioned this pull request Oct 20, 2020
Merged
@nickboldt
Copy link
Contributor

cherry pick to 7.20.x: #501

tolusha added a commit that referenced this pull request Oct 21, 2020
@nickboldt @tolusha
Deprecate server:start command (#486) (#501)
80bd79b 
* Deprecate server:start command

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorhun mmorhun mmorhun approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@nickboldt nickboldt Awaiting requested review from nickboldt

@vparfonov vparfonov Awaiting requested review from vparfonov

@flacatus flacatus Awaiting requested review from flacatus

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr

Assignees

@mmorhun mmorhun

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tolusha @openshift-ci-robot @openshift-merge-robot @nickboldt @mmorhun