Add support for configuring devfile registry #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metlos
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
davidfestal
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
That seems OK for me.
I'll rebase the work I started on issue redhat-developer/rh-che#1476 on master when this PR is merged.
l0rd
approved these changes
Jul 16, 2019
|
That's related to endgame issue eclipse-che/che#13557 |
|
Successfully tested it on Openshift V4. LGTM. |
nickboldt
reviewed
Jul 16, 2019
| @@ -71,7 +73,7 @@ func GetCustomConfigMapData() (cheEnv map[string]string) { | |||
| "CHE_INFRA_KUBERNETES_SERVICE__ACCOUNT__NAME": "che-workspace", | |||
| "CHE_WORKSPACE_AUTO_START": "true", | |||
| "CHE_INFRA_KUBERNETES_WORKSPACE__UNRECOVERABLE__EVENTS": "FailedMount,FailedScheduling,MountVolume.SetUp failed,Failed to pull image", | |||
| "CHE_LIMITS_WORKSPACE_IDLE_TIMEOUT": "-1", | |||
| "CHE_LIMITS_WORKSPACE_IDLE_TIMEOUT": "-1", | |||
There was a problem hiding this comment.
weird indent here but not a showstopper
nickboldt
reviewed
Jul 16, 2019
| @@ -28,6 +28,7 @@ const ( | |||
| DefaultIngressClass = "nginx" | |||
| DefaultPluginRegistryUrl = "https://che-plugin-registry.openshift.io" | |||
| DefaultUpstreamPluginRegistryUrl = "https://che-plugin-registry.openshift.io/v3" | |||
| DefaultDevfileRegistryUrl = "https://che-devfile-registry.openshift.io" | |||
There was a problem hiding this comment.
will these eventually change to be part of the Che deployment, once the registries are local to the deployment rather than shared instances on openshift.io?
There was a problem hiding this comment.
Yes, I will change that in a next PR
nickboldt
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support che-incubator/chectl#114 (implemented in che-incubator/chectl#189).