Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18292 - switch to use quay copies of... #542

Closed

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Nov 18, 2020

18292 - switch to use quay copies of docker.io images

fix for eclipse-che/che#18292

Change-Id: I8503ce14a8821007e9cdb3f6542cbc37e044cb7c
Signed-off-by: nickboldt nboldt@redhat.com

Change-Id: I8503ce14a8821007e9cdb3f6542cbc37e044cb7c
Signed-off-by: nickboldt <nboldt@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt
Copy link
Contributor Author

nickboldt commented Nov 19, 2020

with #544 being merged, do we still need this?

I figure yes, since the copied images will not have rate limit issues for customers when they pull them around in their clusters.

But a more permanent solution in eclipse-che/che#18292 might be even better

@openshift-ci-robot
Copy link

@nickboldt: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nickboldt
Copy link
Contributor Author

@benoitf @davidfestal @tolusha do you want me to rebase this? If we don't want it, please feel free to just close it

@tolusha
Copy link
Contributor

tolusha commented Dec 7, 2020

Closed if favor of #569

@tolusha tolusha closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants