Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create initial Openshift 4 user for oAuth #597

Merged
merged 72 commits into from
Feb 15, 2021
Merged

Create initial Openshift 4 user for oAuth #597

merged 72 commits into from
Feb 15, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Dec 27, 2020 •
edited

What does pr do:

Create initial Openshift 4 user for oAuth if there are no identity providers.

Screenshot from 2021-01-26 12-05-58

Referenced issue:

eclipse-che/che#18152

@AndrienkoAleksandr
Create initial Openshift 4 user for oAuth.
81d0cb6 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Add todo.
4e096cf 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@tolusha tolusha mentioned this pull request Dec 28, 2020
Closed
79 tasks
@tolusha tolusha mentioned this pull request Jan 15, 2021
Closed
54 tasks
@AndrienkoAleksandr
Add ability remove initial user. Fix tests: rework code to make it mo…
b895518 
…re testable.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Fix format.
e1601f3 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr changed the title [draft] Create initial Openshift 4 user for oAuth Create initial Openshift 4 user for oAuth Jan 26, 2021
@AndrienkoAleksandr
Fix clean up initial user secret in the cr status.
b5774b0 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
tolusha
tolusha reviewed Jan 26, 2021
View reviewed changes
deploy/cluster_role.yaml Outdated Show resolved Hide resolved
pkg/apis/org/v1/che_types.go Outdated Show resolved Hide resolved
pkg/apis/org/v1/che_types.go Outdated Show resolved Hide resolved
pkg/util/process.go Outdated Show resolved Hide resolved
pkg/controller/che/initial_htpasswd_provider.go Outdated Show resolved Hide resolved
pkg/controller/che/initial_htpasswd_provider.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller_test.go Outdated Show resolved Hide resolved
pkg/controller/che/initial_htpasswd_provider.go Outdated Show resolved Hide resolved
AndrienkoAleksandr and others added 7 commits January 28, 2021 13:10
@AndrienkoAleksandr @tolusha
Update pkg/apis/org/v1/che_types.go
314d1fa 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/apis/org/v1/che_types.go
fbad512 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/util/process.go
09ec50e 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/initial_htpasswd_provider.go
c9b2f3e 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr
Improve tests. Format cluster-role.yaml.
31d8c30 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Address code review changes.
4659767 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Use che flavour in the oAuth userName.
17c2888 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Merge remote-tracking branch 'upstream/master' into createInitialOpen…
c6c7299 
…shift4UserForOAuth
@AndrienkoAleksandr
Fix format
af1fb81 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Update OLM bundle
35f38c5 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Update crd.
5ee9fb1 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Fix cr yaml.
a7393b1 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Update bundle.
9be3a81 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
tolusha
tolusha reviewed Feb 12, 2021
View reviewed changes
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/oauth_initial_htpasswd_provider.go Outdated Show resolved Hide resolved
pkg/controller/che/oauth_initial_htpasswd_provider.go Outdated Show resolved Hide resolved
pkg/controller/che/oauth_initial_htpasswd_provider.go Outdated Show resolved Hide resolved
pkg/controller/che/oauth_initial_htpasswd_provider.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Show resolved Hide resolved
pkg/controller/che/oauth_initial_htpasswd_provider.go Outdated Show resolved Hide resolved
pkg/controller/che/oauth_initial_htpasswd_provider.go Show resolved Hide resolved
AndrienkoAleksandr and others added 11 commits February 12, 2021 10:25
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/che_controller.go
bb57d71 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/oauth_initial_htpasswd_provider.go
51277e1 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/oauth_initial_htpasswd_provider.go
98c1317 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/oauth_initial_htpasswd_provider.go
9a6aeee 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/che_controller.go
8c3eb27 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/che_controller.go
ddc25dc 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/oauth_initial_htpasswd_provider.go
17a3089 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/oauth_initial_htpasswd_provider.go
633fab2 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/oauth_initial_htpasswd_provider.go
0adba76 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr
Fix up.
471e2e5 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Improve code.
2382fb4 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
tolusha
tolusha approved these changes Feb 12, 2021
View reviewed changes
pkg/controller/che/oauth_initial_htpasswd_provider.go Show resolved Hide resolved
pkg/controller/che/update.go Outdated Show resolved Hide resolved
pkg/controller/che/update.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AndrienkoAleksandr
Improve code.
4b5aed9 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@AndrienkoAleksandr
Update olm files.
5a81b47 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Fix one bug.
74ebb5e 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Fix logs. Fix user deletion: first off all we should remove secret, t…
32301ac 
…hen user, identity and update oauth.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Merge remote-tracking branch 'upstream/master' into createInitialOpen…
bb55041 
…shift4UserForOAuth
@AndrienkoAleksandr
Fix up.
269ae7f 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr merged commit 9702679 into eclipse-che:master Feb 15, 2021
@che-bot che-bot added this to the 7.27 milestone Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@nickboldt nickboldt Awaiting requested review from nickboldt

@flacatus flacatus Awaiting requested review from flacatus

@mmorhun mmorhun Awaiting requested review from mmorhun

Assignees

@tolusha tolusha

Labels
None yet
Projects
None yet
Milestone
7.27
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndrienkoAleksandr @openshift-ci-robot @tolusha @che-bot