Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure domain to create routes #666

Merged
merged 4 commits into from
Feb 15, 2021
Merged

Conversation

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #666 (46d7957) into master (9702679) will increase coverage by 1.70%.
The diff coverage is 29.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   28.69%   30.39%   +1.70%     
==========================================
  Files          49       49              
  Lines        5193     5238      +45     
==========================================
+ Hits         1490     1592     +102     
+ Misses       3469     3400      -69     
- Partials      234      246      +12     
Impacted Files Coverage Δ
pkg/deploy/devfile-registry/devfile_registry.go 0.00% <0.00%> (ø)
pkg/deploy/identity-provider/identity_provider.go 13.57% <0.00%> (+0.19%) ⬆️
pkg/deploy/plugin-registry/plugin_registry.go 0.00% <0.00%> (ø)
pkg/deploy/tls.go 0.00% <0.00%> (ø)
pkg/util/test_util.go 0.00% <0.00%> (ø)
pkg/controller/che/che_controller.go 19.68% <42.10%> (+0.55%) ⬆️
pkg/deploy/server/che_configmap.go 75.43% <47.05%> (+8.37%) ⬆️
pkg/deploy/ingress.go 40.00% <50.00%> (+40.00%) ⬆️
pkg/deploy/secret.go 9.58% <50.00%> (+2.34%) ⬆️
pkg/deploy/route.go 35.16% <83.33%> (+35.16%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562246c...46d7957. Read the comment docs.

APIVersion: "org.eclipse.che/v1",
Kind: "CheCluster",
Controller: &_true,
BlockOwnerDeletion: &_true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use util.NewBoolPointer(true)

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha merged commit 2f5ec20 into master Feb 15, 2021
@tolusha tolusha deleted the configureroutedomain branch February 15, 2021 14:47
@che-bot che-bot added this to the 7.27 milestone Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants