-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure domain to create routes #666
Conversation
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 28.69% 30.39% +1.70%
==========================================
Files 49 49
Lines 5193 5238 +45
==========================================
+ Hits 1490 1592 +102
+ Misses 3469 3400 -69
- Partials 234 246 +12
Continue to review full report at Codecov.
|
0e46966
to
9b36595
Compare
pkg/deploy/ingres_test.go
Outdated
APIVersion: "org.eclipse.che/v1", | ||
Kind: "CheCluster", | ||
Controller: &_true, | ||
BlockOwnerDeletion: &_true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use util.NewBoolPointer(true)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
e25c84c
to
46d7957
Compare
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Allow to configure domain for routes.
The host will be constructed as
<route-name>-<namespace>.<domain>
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1466
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.