Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure github and bitbucket oauth config #677

Merged
merged 7 commits into from
Feb 17, 2021
Merged

Conversation

@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #677 (4d0be05) into master (5f2b348) will increase coverage by 0.96%.
The diff coverage is 67.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   30.39%   31.35%   +0.96%     
==========================================
  Files          49       49              
  Lines        5238     5361     +123     
==========================================
+ Hits         1592     1681      +89     
- Misses       3400     3422      +22     
- Partials      246      258      +12     
Impacted Files Coverage Δ
pkg/deploy/defaults.go 46.52% <ø> (ø)
pkg/util/test_util.go 0.00% <0.00%> (ø)
pkg/util/util.go 10.30% <0.00%> (-0.17%) ⬇️
pkg/deploy/postgres/deployment_postgres.go 73.25% <28.57%> (+0.15%) ⬆️
pkg/deploy/identity-provider/identity_provider.go 14.38% <66.66%> (+0.81%) ⬆️
...kg/deploy/identity-provider/deployment_keycloak.go 51.57% <71.05%> (+1.65%) ⬆️
pkg/deploy/secret.go 24.73% <80.00%> (+15.14%) ⬆️
pkg/deploy/server/che_configmap.go 75.80% <80.00%> (+0.36%) ⬆️
pkg/deploy/server/deployment_che.go 64.67% <80.00%> (+2.25%) ⬆️
pkg/deploy/deployment.go 45.36% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2b348...4d0be05. Read the comment docs.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should at least log warning if we detected more than one secret...

@tolusha
Copy link
Contributor Author

tolusha commented Feb 17, 2021

The problem with a message that it will be printed on every reconcile loop.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 75da259 into master Feb 17, 2021
@tolusha tolusha deleted the che-18932 branch February 17, 2021 12:32
@che-bot che-bot added this to the 7.27 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants