Configure the operator to deploy airgapped versions of the devfile and plugin registries #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata to che configmap if we are in airgap mode Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
tomgeorge
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
tomgeorge
changed the title
tomgeorge
changed the title
davidfestal
requested changes
Oct 11, 2019
davidfestal
requested changes
Oct 11, 2019
There was a problem hiding this comment.
And you will also have to cope with this comment: eclipse-che/che-devfile-registry#112 (review) for offline.
Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
…roperty occurs Signed-off-by: Tom George <tg82490@gmail.com>
Signed-off-by: Tom George <tg82490@gmail.com>
davidfestal
approved these changes
Oct 14, 2019
davidfestal
changed the title
l0rd
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the operator to configure the devfile and plugin registries to work with airgap mode as per eclipse-che/che#14734.
It creates two configmaps, devfile-registry and plugin-registry, and adds the values of
airGapContainerRegistryHostnameandairGapContainerRegistryOrganizationto it, and sets the deployments to optionally reference those configmaps.