chore: generate networking.k8s.io/v1 version of Ingress #992
Conversation
tolusha
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun and
nickboldt
as code owners
bundle/next/eclipse-che-preview-openshift/manifests/che-operator.clusterserviceversion.yaml
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - apiGroups: | ||
| - networking.k8s.io | ||
| resources: | ||
| - ingresses | ||
| verbs: | ||
| - '*' |
There was a problem hiding this comment.
This supercedes the permission above (line 473--482)
There was a problem hiding this comment.
The first ones are cluster roles another one are just roles.
| @@ -28,7 +28,7 @@ import ( | |||
| "github.com/sirupsen/logrus" | |||
| appsv1 "k8s.io/api/apps/v1" | |||
| corev1 "k8s.io/api/core/v1" | |||
| extv1beta1 "k8s.io/api/extensions/v1beta1" | |||
| networking "k8s.io/api/networking/v1" | |||
There was a problem hiding this comment.
To match the other names
| networking "k8s.io/api/networking/v1" | |
| networkingv1 "k8s.io/api/networking/v1" |
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/apimachinery/pkg/util/intstr" | ||
| "k8s.io/utils/pointer" |
|
/retest |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
@tolusha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* chore: generate networking.k8s.io/v1 version of Ingress Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Generates networking.k8s.io/v1 version of Ingress
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20182
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.