Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Limit new all-namespaces-stable channel to OpenShift 4.8+ #997

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2021

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v7-stable-to-nightly cb3bde1 link /test v7-stable-to-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2021
@mmorhun mmorhun removed their assignment Aug 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 09d81f8 into main Aug 6, 2021
@tolusha tolusha deleted the 20234 branch August 6, 2021 09:32
@che-bot che-bot added this to the 7.35 milestone Aug 6, 2021
tolusha added a commit that referenced this pull request Aug 6, 2021
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@nickboldt
Copy link
Contributor

Does this change actually work? Asking because https://issues.redhat.com/browse/CRW-2138 suggests to me that we can't set a version other than 4.5 (old format appstream) or 4.6 (new format iib bundle).

@tolusha
Copy link
Contributor Author

tolusha commented Aug 6, 2021

@nickboldt
Maybe because of that

NOTE: Commas are generally not allowed, and should not be used. For historical reasons, there are two special values that are currently allowed, v4.5,v4.6 and v4.6,v4.5. Both behave as just v4.5. The operator is supported on the v4.5 version of OpenShift or later. Any other usage of commas, e.g. v4.6,v4.7, will prevent the operator from being added to the certified catalog.

@tolusha
Copy link
Contributor Author

tolusha commented Aug 6, 2021

I don't see why v4.8 won't work.
But I will try to build a bundle and test.
Thank you for bringing this up.

@tolusha
Copy link
Contributor Author

tolusha commented Aug 9, 2021

Doc [1] proves that LABEL com.redhat.openshift.versions="v4.8" works

[1] https://access.redhat.com/documentation/en-us/openshift_container_platform/4.8/html-single/operators/index
(4.8.5. Controlling Operator compatibility with OpenShift Container Platform versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants