Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

[WIP] Use localhost in plugin endpoints by default #56

Closed
wants to merge 2 commits into from
Closed

[WIP] Use localhost in plugin endpoints by default #56

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff4617e
Use `localhost` in plugin endpoints by default
davidfestal May 3, 2019
b0c3cfb
Don't add the endpoint when using `localhost`
davidfestal May 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion cfg/cfg.go
View file
Open in desktop
Expand Up @@ -53,7 +53,8 @@ var (
// UseLocalhostInPluginUrls configures the broker to use the `localhost` name
// instead of the Kubernetes service name to build Theia or VSCode plugin
// endpoint URL
UseLocalhostInPluginUrls bool
// True by default, at least as long as all the plugin containers are in the same POD
UseLocalhostInPluginUrls = true
davidfestal marked this conversation as resolved.
Show resolved Hide resolved

// OnlyApplyMetadataActions configures the broker to only apply metadata-related
// steps, without copying any file into the `plugins` directory
Expand Down