feat: Add volume mount to the runtime binary container #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
requested review from
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Click here to review and test in web IDE: |
azatsarynnyy
approved these changes
Sep 27, 2021
benoitf
approved these changes
Sep 27, 2021
benoitf
changed the title
svor
approved these changes
Sep 27, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: azatsarynnyy, benoitf, svor, vzhukovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of eclipse-che/che-theia#1222
Container
theia-endpoint-runtime-binarynow requires volume mount/plugins.Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1731
How to test this PR?
See test section in: eclipse-che/che-theia#1222
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.