Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: find a first stable and compatible version of the extension to include it into the embedded plugin registry #1679

Merged
merged 1 commit into from May 16, 2023

Conversation

svor
Copy link
Contributor

@svor svor commented May 10, 2023

What does this PR do?

Finds latest and stable version for each extension that is going to be included into the embedded plugin registry.
Also it checks that vscode engine version in the extension is compatible with Che Code version.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4165
https://issues.redhat.com/browse/CRW-4336

How to test this PR?

  • Run che with current version of plugin registry
  • Activate embedded plugin registry
  • Check that latest stable version of vscode-java extension (redhat.java-1.18.0) is available and it's possible to install it

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…de it into embedded registry

Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
@svor svor requested a review from nickboldt May 10, 2023 12:47
@svor svor self-assigned this May 10, 2023
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this is the same as / equivalent to the PR I reviewed for downstream (which I can't find right now) ... then +1

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt requested a review from SDawley May 10, 2023 19:23
@SDawley
Copy link
Contributor

SDawley commented May 10, 2023

This is really helpful information to have, and for most of the plugins I can probably use this to determine what versions to build in https://github.com/redhat-developer/devspaces-vscode-extensions/blob/devspaces-3-rhel-8/plugin-config.json, but there are a number of plugins where the tags in the source repo don't match the version in openvsx, or they don't use tags at all.

So, in those cases (https://github.com/microsoft/vscode-jupyter-keymap.git for example) what should the process for devspaces be?

Can we capture the versions used in che into a manifest or something? Then I can just translate those into version/revisions for the RH internal builds. Hopefully I can find something better than manually hunting down commit sha's for the repos that don't use tags.

@svor
Copy link
Contributor Author

svor commented May 11, 2023

assuming this is the same as / equivalent to the PR I reviewed for downstream (which I can't find right now) ... then +1

yes, it is equivalent changes that were done in DS,
downstream PR was merged redhat-developer/devspaces#954

@svor
Copy link
Contributor Author

svor commented May 11, 2023

@SDawley with this PR redhat-developer/devspaces#954 DS has the same logic.
It analyzes manifests from the openv-vsx.org to get vsix files with the latest stable version and actually it adds versions for each extension into resulted openvsx-sync.json.

The path of resulted openvsx-sync.json is /openvsx-server/openvsx-sync.json (in DS plugin registry image) and the content is:

The resulted openvsx-sync.json with versions is:
[
  {
    "id": "donjayamanne.githistory",
    "version": "0.6.20"
  },
  {
    "id": "vscode.github-authentication",
    "version": "1.70.2"
  },
  {
    "id": "github.vscode-pull-request-github",
    "version": "0.62.0"
  },
  {
    "id": "ms-vscode.js-debug",
    "version": "1.78.0"
  },
  {
    "id": "vscode.typescript-language-features",
    "version": "1.70.2"
  },
  {
    "id": "llvm-vs-code-extensions.vscode-clangd",
    "version": "0.1.24"
  },
  {
    "id": "eclipse-cdt.cdt-gdb-vscode",
    "version": "0.0.96"
  },
  {
    "id": "bmewburn.vscode-intelephense-client",
    "version": "1.9.5"
  },
  {
    "id": "ms-python.python",
    "version": "2023.8.0"
  },
  {
    "id": "ms-toolsai.jupyter",
    "version": "2023.3.100"
  },
  {
    "id": "ms-toolsai.jupyter-keymap",
    "version": "1.1.0"
  },
  {
    "id": "ms-toolsai.jupyter-renderers",
    "version": "1.0.15"
  },
  {
    "id": "ms-toolsai.vscode-jupyter-cell-tags",
    "version": "0.1.8"
  },
  {
    "id": "ms-toolsai.vscode-jupyter-slideshow",
    "version": "0.1.5"
  },
  {
    "id": "golang.go",
    "version": "0.38.0"
  },
  {
    "id": "redhat.vscode-yaml",
    "version": "1.12.2"
  },
  {
    "id": "ms-kubernetes-tools.vscode-kubernetes-tools",
    "version": "1.3.11"
  },
  {
    "id": "redhat.java",
    "version": "1.18.0"
  },
  {
    "id": "vscjava.vscode-java-debug",
    "version": "0.50.0"
  },
  {
    "id": "vscjava.vscode-java-test",
    "version": "0.38.2"
  },
  {
    "id": "redhat.vscode-microprofile",
    "version": "0.7.1"
  },
  {
    "id": "vscode.html-language-features",
    "version": "1.70.2"
  },
  {
    "id": "redhat.vscode-quarkus",
    "version": "1.13.0"
  },
  {
    "id": "redhat.fabric8-analytics",
    "version": "0.3.6"
  },
  {
    "id": "redhat.project-initializer",
    "version": "0.2.2"
  },
  {
    "id": "redhat.vscode-redhat-account",
    "version": "0.1.0"
  },
  {
    "id": "redhat.vscode-openshift-connector",
    "version": "1.2.0"
  },
  {
    "id": "xdebug.php-debug",
    "version": "1.32.1"
  },
  {
    "id": "redhat.vscode-xml",
    "version": "0.25.0"
  },
  {
    "id": "muhammad-sammy.csharp",
    "version": "1.25.0"
  },
  {
    "id": "sonarsource.sonarlint-vscode",
    "version": "3.17.0"
  },
  {
    "id": "vscode.git-base",
    "version": "1.70.2"
  },
  {
    "id": "vscode.git",
    "version": "1.70.2"
  },
  {
    "id": "dbaeumer.vscode-eslint",
    "version": "2.4.0"
  },
  {
    "id": "redhat.vscode-commons",
    "version": "0.0.6"
  },
  {
    "id": "redhat.vscode-tekton-pipelines",
    "version": "1.0.1"
  },
  {
    "id": "atlassian.atlascode",
    "version": "3.0.3"
  },
  {
    "id": "JFrog.jfrog-vscode-extension",
    "version": "2.3.0"
  },
  {
    "id": "SonatypeCommunity.vscode-iq-plugin",
    "version": "1.3.3"
  },
  {
    "id": "GitLab.gitlab-workflow",
    "version": "3.62.0"
  },
  {
    "id": "timonwong.shellcheck",
    "version": "0.32.5"
  },
  {
    "id": "redhat.ansible",
    "version": "2.0.58"
  },
  {
    "id": "vscode.npm",
    "version": "1.70.2"
  },
  {
    "id": "esbenp.prettier-vscode",
    "version": "9.12.0"
  },
  {
    "id": "eamodio.gitlens",
    "version": "13.5.0"
  }
]

@svor svor merged commit b16ed61 into main May 16, 2023
16 checks passed
@svor svor deleted the sv-find-latest-stable-vsix branch May 16, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants