-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add next version for che-machine-exec. #194
Add next version for che-machine-exec. #194
Conversation
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
apiVersion: v2 | ||
publisher: eclipse | ||
name: che-machine-exec-plugin | ||
version: 0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it 0.0.1 or next?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr are you going to update https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L665 as well to point to version And when we are release Che we need to release
@AndrienkoAleksandr @vparfonov are you ok with this approach? |
- name: che-machine-exec | ||
image: eclipse/che-machine-exec | ||
ports: | ||
- exposedPort: 4444 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you are missing a newline here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
After merge this pr che.properties will update @vparfonov
+1 I am OK with this approach. |
@l0rd Are you Ok if I merge this pr? |
Referenced issue:
eclipse-che/che#13970
What does this PR do?
Add next version for che-machine-exec. This version with activated security endpoint.
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com