Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next version for che-machine-exec. #194

Merged
merged 4 commits into from
Jul 29, 2019

Conversation

AndrienkoAleksandr
Copy link
Contributor

Referenced issue:

eclipse-che/che#13970

What does this PR do?

Add next version for che-machine-exec. This version with activated security endpoint.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
apiVersion: v2
publisher: eclipse
name: che-machine-exec-plugin
version: 0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it 0.0.1 or next?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@l0rd
Copy link
Contributor

l0rd commented Jul 29, 2019

@AndrienkoAleksandr are you going to update https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L665 as well to point to version next?

And when we are release Che we need to release che-machine-exec as well:

  • use a tag for the container image and on the git repository (7.0.0)
  • add the che-machine-exec-plugin version 7.0.0. (in the `che-plugin-registry)
  • update che.properties to use che-machine-exec-plugin version 7.0.0

@AndrienkoAleksandr @vparfonov are you ok with this approach?

- name: che-machine-exec
image: eclipse/che-machine-exec
ports:
- exposedPort: 4444
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are missing a newline here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

@AndrienkoAleksandr are you going to update https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L665 as well to point to version next?

After merge this pr che.properties will update @vparfonov

And when we are release Che we need to release che-machine-exec as well:
use a tag for the container image and on the git repository (7.0.0)
add the che-machine-exec-plugin version 7.0.0. (in the `che-plugin-registry)
update che.properties to use che-machine-exec-plugin version 7.0.0

+1 I am OK with this approach.

@AndrienkoAleksandr
Copy link
Contributor Author

@l0rd Are you Ok if I merge this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants