Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java support #239

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Update java support #239

merged 1 commit into from
Oct 7, 2019

Conversation

svor
Copy link
Contributor

@svor svor commented Oct 4, 2019

What does this PR do?

  • Adds java plugin v0.50.0
  • Updates latest java plugin
  • Updates java-debug plugin to v0.20.0
  • Adds /home/theia/.m2 volume for java plugin

Related issue:
eclipse-che/che#14649
eclipse-che/che#13603

Signed-off-by: svor <vsvydenk@redhat.com>
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amisevsk
Copy link
Contributor

amisevsk commented Oct 4, 2019

One feature that I don't know was intentional but is still very nice is that the mounted .m2 repo is shared between the plugin container and the main java container (assuming the main container also mounts .m2)

@svor svor merged commit cf4e592 into master Oct 7, 2019
@svor svor deleted the sv/jdtls50 branch October 7, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants