Allow overriding sidecar images at runtime using environment variables #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
force-pushed
the
specify-images
branch
2 times, most recently
from
4110dbc
to
c6cdcf6
Compare
davidfestal
requested changes
Oct 7, 2019
deploy/kubernetes/che-plugin-registry/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
davidfestal
approved these changes
Oct 8, 2019
amisevsk
force-pushed
the
specify-images
branch
from
c6ca019
to
111838d
Compare
|
Rebased onto current master |
amisevsk
force-pushed
the
specify-images
branch
3 times, most recently
from
edbdfa4
to
8299ea3
Compare
Add entrypoint script to registry docker images that allows overriding
images used in plugin sidecars with a user-defined registry, organization,
and tag, according to env vars
CHE_SIDECAR_CONTAINERS_REGISTRY_URL
CHE_SIDECAR_CONTAINERS_REGISTRY_ORGANIZATION
CHE_SIDECAR_CONTAINERS_REGISTRY_TAG
Additionally:
- Reorganize repo so that build artifacts are in one place
- Update build.sh script to take basic options.
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
specify-images
branch
from
8299ea3
to
4136da8
Compare
ibuziuk
added a commit
to openshiftio/saas-openshiftio
that referenced
this pull request
Oct 21, 2019
The new deployment path has been introduced in the eclipse-che/che-plugin-registry#245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows users to override the registry, organization, and tag of sidecar images for all plugins at runtime, using the environment variables
This PR consists of
45 commits, to make reviewing easier:./build/dockerfilesand scripts to./build/scripts).entrypoint.shscript to the docker images, which consumes the environment variables above--latest-onlyin thebuild.shscript.Related Issue
eclipse-che/che#14693