Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping version to 7.8.0-SNAPSHOT in master. Adding 7.7.0 che-theia / machine-exec plugins + fixing container runtime image for quarkus plugin #339

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Jan 8, 2020

What does this PR do?

Related issue - eclipse-che/che#15609

  • Fixing the container runtime image for the quarkus plugin
  • Bumping version to 7.8.0- SNAPSHOT
  • Adding '7.7.0' versions of the che-theai and machine-exec plugins

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
…plugins and bumping the latest.txt files of those plugins

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if the "fixing container runtime image for quarkus plugin" part was a separate commit so we can more easily cherrypick it to 7.7x branch, so please don't squash merge. +1.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 8, 2020

@nickboldt well, this is a fixup due to bug in the #291
I had to this fix also in the release PR - #338

separate commit so we can more easily cherrypick it to 7.7x branch

and btw, it is a separate commit ;-)

@nickboldt nickboldt merged commit 49ba9d5 into eclipse-che:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants