Run Happy Path tests using github actions #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
ericwill,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
benoitf
force-pushed
the
happy-path-github-actions
branch
from
0365f60
to
0f0faca
Compare
ericwill
reviewed
Jan 18, 2021
.github/workflows/happy-path.yaml
Outdated
| # matrix jobs with alpine and ubi8 | ||
| name: Happy Path | ||
|
|
||
| on: [push, pull_request] |
There was a problem hiding this comment.
This will run for sidecar update PRs, which I don't think is testing anything because the generated meta.yaml files won't be referencing it. Maybe it should only run on updates to che*.yaml files?
There was a problem hiding this comment.
If you change a sh script or Dockerfile or build library, etc it requires as well to be tested
Maybe everything except sidecars folder ?
benoitf
force-pushed
the
happy-path-github-actions
branch
2 times, most recently
from
5cf6133
to
4a96d4c
Compare
ericwill
approved these changes
Jan 18, 2021
benoitf
force-pushed
the
happy-path-github-actions
branch
from
4a96d4c
to
fc760da
Compare
Check with each change on the plug-in registry And check with both Alpine and UBI8 images Change-Id: I1b3a01712e45dfd35cc5a8ee94b2ac4ba51e22d5 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
happy-path-github-actions
branch
from
fc760da
to
302f35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check with each change on the plug-in registry
And check with both Alpine and UBI8 images
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#18747
How to test this PR?
Check PR check result. Should be green
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Change-Id: I1b3a01712e45dfd35cc5a8ee94b2ac4ba51e22d5
Signed-off-by: Florent Benoit fbenoit@redhat.com