chore(build-check): Add check script to verify that docker images used in registry are valid

[sunix]

Signed-off-by: Sun Tan sutan@redhat.com

What does this PR do?

Check that each images used in the registry are valid

Screenshot/screencast of this PR

Failing:

What issues does this PR fix or reference?

Fix eclipse-che/che#18747

How to test this PR?

• Clone the repo and checkout the branch of this PR
• build the registry image
• check that it is working fine
• change https://github.com/eclipse/che-plugin-registry/blob/835b5318669141b43c6ca2013224d69fac6000cd/che-theia-plugins.yaml#L320, replacing quay.io/windupeng/mta-vscode-extension:latest with quay.io/windupeng/mta-vscode-extension:wrongtag
• restart the build and see that it is failing

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[ericwill]

Hey Sun, a few things:

• We have a PR check that runs digest-validation-pr.sh. After this change it won't be needed (build runs on every PR) so it can be removed
• If the build runs with USE_DIGESTS=true, then skopeo inspect will be run twice -- maybe run yours only if USE_DIGESTS=false?
  • In other places where skopeo inspect is called, the option --tls-verify=false is specified. Do we need that here too?

[benoitf]

FYI i've an upcoming PR that remove all .sh scripts, everything being checked when generating files.

[sunix]

I suggest that we postpone the work to be done for these checks, and see/discuss what to do after Florent's PR merged. @ericwill works for you?

[ericwill]

I suggest that we postpone the work to be done for these checks, and see/discuss what to do after Florent's PR merged. @ericwill works for you?

Sounds good to me.

[benoitf]

FYI #815 here is the related PR

[sunix]

@benoitf could you confirm that these checks won't be necessary anymore with #815 ?

[benoitf]

yes I confirm that as digests are retrieved, it's ensuring that the image/tag do exists
If not, there will be a build failure

[sunix]

yes I confirm that as digests are retrieved, it's ensuring that the image/tag do exists
If not, there will be a build failure

OK I am closing this one so