Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruby): Re enabling ruby plugin #841

Merged
merged 1 commit into from
Feb 16, 2021
Merged

fix(ruby): Re enabling ruby plugin #841

merged 1 commit into from
Feb 16, 2021

Conversation

sunix
Copy link
Contributor

@sunix sunix commented Feb 16, 2021

What does this PR do?

Ruby plugin was disabled https://github.com/eclipse/che-plugin-registry/pull/829/files
Re enabling ruby plugin now that it is available: castwide/vscode-solargraph#204 (comment)

Screenshot/screencast of this PR

Selection_235

What issues does this PR fix or reference?

How to test this PR?

try the devfile:

apiVersion: 1.0.0
metadata:
  generateName: ruby-test-reenabling-
projects:
  - name: rails-mister-cocktail
    source:
      location: 'https://github.com/omontigny/rails-mister-cocktail'
      type: github
components:
  - id: castwide/solargraph/latest
    registryUrl: 'https://sunix-plugin-registry-ruby-z6b4p.surge.sh/v3/'
    type: chePlugin

open a .rb file and try auto complete.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Sun Tan <sutan@redhat.com>
@benoitf
Copy link
Contributor

benoitf commented Feb 16, 2021

Tested. completion works as expected
https://user-images.githubusercontent.com/436777/108063528-a3f4db00-705b-11eb-85a4-54de308750ea.mp4

But it would be cool if you disable the check-for-updates

because opening the workspace, I've a bottom right popup telling me that there is a new version available

image

@sunix
Copy link
Contributor Author

sunix commented Feb 16, 2021

Tested. completion works as expected
https://user-images.githubusercontent.com/436777/108063528-a3f4db00-705b-11eb-85a4-54de308750ea.mp4

But it would be cool if you disable the check-for-updates

because opening the workspace, I've a bottom right popup telling me that there is a new version available

image

OK @benoitf could you file an issue for that ?

@benoitf
Copy link
Contributor

benoitf commented Feb 16, 2021

@sunix eclipse-che/che#19079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants