Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Omit default branch for GitLab repositories as it is not always 'master' #34

Merged
merged 2 commits into from Jun 17, 2021

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Jun 16, 2021

What does this PR do?

Fixes the GitLab file reading behavior, by omitting master branch name by default.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-1929

How to test this PR?

Before PR: Accepting factory with GitLab repository, having default branch other than 'master' is failing;
After PR: Accepting factory with GitLab repository, having default branch other than 'master' is OK;

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Release Notes Text

Unable to create a workspace using a factory link to an on-premise GitLab repository

Eclipse Che was unable to create a workspace using a factory link to an on-premise GitLab repository without a branch named `master.

@mshaposhnik mshaposhnik changed the title Fix: Omit default branch for GitLab repositories as it is not always 'master' fix: Omit default branch for GitLab repositories as it is not always 'master' Jun 16, 2021
@che-bot
Copy link
Contributor

che-bot commented Jun 16, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Jun 16, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@mshaposhnik mshaposhnik merged commit 7a09b93 into eclipse-che:main Jun 17, 2021
@che-bot che-bot added this to the 7.33 milestone Jun 17, 2021
@l0rd
Copy link
Contributor

l0rd commented Jun 24, 2021

@mshaposhnik is there any issue associated to this PR? I am asking because we would like to add it to the release notes of 7.32 (and CRW 2.10).

@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jun 24, 2021
@mshaposhnik
Copy link
Contributor Author

mshaposhnik commented Jun 24, 2021

@lord it came from CRW testing, so i have only this: https://issues.redhat.com/browse/CRW-1929

@l0rd
Copy link
Contributor

l0rd commented Jun 24, 2021

@mshaposhnik cool thanks

@l0rd l0rd added the bug Something isn't working label Jun 24, 2021
@che-bot
Copy link
Contributor

che-bot commented Jun 24, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler added status/release-notes-review-done Issues that have been reviewed by the doc team for the Release Notes wording and removed status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jun 29, 2021
@mshaposhnik mshaposhnik deleted the fix_branch branch July 1, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-done Issues that have been reviewed by the doc team for the Release Notes wording
Projects
None yet
5 participants