New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Omit default branch for GitLab repositories as it is not always 'master' #34
Conversation
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
@mshaposhnik is there any issue associated to this PR? I am asking because we would like to add it to the release notes of 7.32 (and CRW 2.10). |
@lord it came from CRW testing, so i have only this: https://issues.redhat.com/browse/CRW-1929 |
@mshaposhnik cool thanks |
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
What does this PR do?
Fixes the GitLab file reading behavior, by omitting
master
branch name by default.Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1929
How to test this PR?
Before PR: Accepting factory with GitLab repository, having default branch other than 'master' is failing;
After PR: Accepting factory with GitLab repository, having default branch other than 'master' is OK;
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Release Notes Text
Unable to create a workspace using a factory link to an on-premise GitLab repository
Eclipse Che was unable to create a workspace using a factory link to an on-premise GitLab repository without a branch named `master.