New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRW-4043 Move dockerfiles to build/dockerfiles #468
Conversation
Signed-off-by: sdawley <sdawley@redhat.com>
…es. Add brew.Dockerfile.
@vinokurig @nickboldt Could one of you review this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably delete this file -- it seems to be related to centos ci builds which we don't do anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme is super outdated. refers to a repo that we don't use. talks about multiple dockerfiles (and now there's just one). includes EPL v1 license (not v2).
Let's just delete that file. @vinokurig WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if build.sh (but not build.include) is just a wrapper for calling build.sh in subfolders... perhaps we can just delete this file since we're only doing a single build/dockerfiles/build.sh with build/dockerfiles/Dockerfile ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is a question for @vinokurig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the script in the /build
directory because the navigating to /build/dockerfiles/
looks more complicated and confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep this as it's used by next-build.yml and build/dockerfiles/build.sh
I've confirmed that while we are currently PUBLISHING these images, we don't refer to them anywhere in the che-operator yaml files (CSV or CRD):
|
@SDawley: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@SDawley is this PR still actual? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SDawley, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
moving to #573 |
What does this PR do?
Moves dockerfiles from dockerfiles/che to build/dockerfiles
Removes the endpoint-watcher, postgres and keycloak images.
Adds brew.Dockerfile from downstream.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4043
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.