Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRW-4043 Move dockerfiles to build/dockerfiles #468

Closed
wants to merge 4 commits into from

Conversation

SDawley
Copy link
Contributor

@SDawley SDawley commented Mar 17, 2023

What does this PR do?

Moves dockerfiles from dockerfiles/che to build/dockerfiles
Removes the endpoint-watcher, postgres and keycloak images.
Adds brew.Dockerfile from downstream.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4043

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@SDawley
Copy link
Contributor Author

SDawley commented Mar 21, 2023

@vinokurig @nickboldt Could one of you review this please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably delete this file -- it seems to be related to centos ci builds which we don't do anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme is super outdated. refers to a repo that we don't use. talks about multiple dockerfiles (and now there's just one). includes EPL v1 license (not v2).

Let's just delete that file. @vinokurig WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@nickboldt nickboldt Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if build.sh (but not build.include) is just a wrapper for calling build.sh in subfolders... perhaps we can just delete this file since we're only doing a single build/dockerfiles/build.sh with build/dockerfiles/Dockerfile ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a question for @vinokurig

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the script in the /build directory because the navigating to /build/dockerfiles/ looks more complicated and confusing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to keep this as it's used by next-build.yml and build/dockerfiles/build.sh

@nickboldt
Copy link
Contributor

I've confirmed that while we are currently PUBLISHING these images, we don't refer to them anywhere in the che-operator yaml files (CSV or CRD):

  • quay.io/eclipse/che-endpoint-watcher
  • quay.io/eclipse/che-keycloak
  • quay.io/eclipse/che-postgres

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@SDawley: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v12-bitbucket-no-pat-oauth-flow e102fdc link true /test v12-bitbucket-no-pat-oauth-flow
ci/prow/v12-gitlab-with-pat-setup-flow e102fdc link true /test v12-gitlab-with-pat-setup-flow
ci/prow/v12-github-with-pat-setup-flow e102fdc link true /test v12-github-with-pat-setup-flow
ci/prow/v12-gitlab-no-pat-oauth-flow e102fdc link true /test v12-gitlab-no-pat-oauth-flow
ci/prow/v12-github-no-pat-oauth-flow e102fdc link true /test v12-github-no-pat-oauth-flow
ci/prow/v12-azure-no-pat-oauth-flow e102fdc link true /test v12-azure-no-pat-oauth-flow
ci/prow/v12-azure-with-pat-setup-flow e102fdc link true /test v12-azure-with-pat-setup-flow
ci/prow/v12-bitbucket-no-pat-oauth-flow-raw-devfile-url e102fdc link true /test v12-bitbucket-no-pat-oauth-flow-raw-devfile-url
ci/prow/v12-bitbucket-no-pat-oauth-flow-ssh-url e102fdc link true /test v12-bitbucket-no-pat-oauth-flow-ssh-url
ci/prow/v12-github-no-pat-oauth-flow-raw-devfile-url e102fdc link true /test v12-github-no-pat-oauth-flow-raw-devfile-url
ci/prow/v12-github-no-pat-oauth-flow-ssh-url e102fdc link true /test v12-github-no-pat-oauth-flow-ssh-url
ci/prow/v12-gitlab-no-pat-oauth-flow-raw-devfile-url e102fdc link true /test v12-gitlab-no-pat-oauth-flow-raw-devfile-url
ci/prow/v12-gitlab-no-pat-oauth-flow-ssh-url e102fdc link true /test v12-gitlab-no-pat-oauth-flow-ssh-url
ci/prow/v12-azure-no-pat-oauth-flow-ssh-url e102fdc link true /test v12-azure-no-pat-oauth-flow-ssh-url
ci/prow/v12-azure-no-pat-oauth-flow-raw-devfile-url e102fdc link true /test v12-azure-no-pat-oauth-flow-raw-devfile-url
ci/prow/v12-git-no-pat-oauth-flow e102fdc link true /test v12-git-no-pat-oauth-flow
ci/prow/v12-gitea-with-pat-setup-flow e102fdc link true /test v12-gitea-with-pat-setup-flow
ci/prow/v12-gitea-no-pat-oauth-flow e102fdc link true /test v12-gitea-no-pat-oauth-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibuziuk
Copy link
Member

ibuziuk commented Sep 26, 2023

@SDawley is this PR still actual?

@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SDawley, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig
Copy link
Contributor

moving to #573

@vinokurig vinokurig closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants