Encode the authentication reject error to build a proper callback url

[vinokurig]

What does this PR do?

Encode the &error_code=access_denied query param for the callback url in order to fix the bug when the authentication request appears again if it was rejected.

DO NOT MERGE until eclipse-che/che-dashboard#932 is merged

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#22499
fixes eclipse-che/che#22539

How to test this PR?

1. Deploy che with the PR image quay.io/eclipse/che-server:pr-568
2. Setup the GitHub oauth flow.
3. Create a workspace from a public GitHub repository.
4. When the authentication page appears, reject the request.

See: the workspace start proceeds without fetching the token.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[tolusha]

Please find the error below:

[vinokurig]

@tolusha

Please find the error below

This is another bug. You can reproduce it even on dogfooding:

1. Start a workspace from a GitHub repository, accept the authorisation as you can not reject it because of this bug.
2. Stop the workspace.
3. Go to dashboard -> user preferences -> git services and revoke the authorisation.
4. Start the workspace and reject the authorisation.

I don't think we should do something with this because according to the issue we will not ask to authorise on workspace start, as the authorisation can be either accepted or rejected once on workspace create step.

The PR does not contain this part as the approach should be clarified with @ibuziuk

[tolusha]

/test v12-bitbucket-no-pat-oauth-flow

[vinokurig]

@tolusha opened a separate issue: eclipse-che/che#22539

[openshift-ci]

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v12-git-no-pat-oauth-flow	acfb9df	link	true	/test v12-git-no-pat-oauth-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[artaleks9]

Verified on Che deployed with

quay.io/eclipse/che-server:pr-568
quay.io/eclipse/che-dashboard:pr-932

The functionality works as expected.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.10 :: server_3.x/250: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4811: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4605: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: push-latest-container-to-quay_3.x/3407: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4605:

server : 3.x :: Build 55793667 : quay.io/devspaces/server-rhel8:3.10-13
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3407 triggered

[devstudio-release]

Build 3.10 :: update-digests_3.x/4458: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: server_3.x/250:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4811 triggered

[devstudio-release]

Build 3.10 :: operator-bundle_3.x/2104: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4812: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4606: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: push-latest-container-to-quay_3.x/3408: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4606:

devspaces-operator-bundle : 3.x :: Build 55793846 : quay.io/devspaces/devspaces-operator-bundle:3.10-87
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3408 triggered;

Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.10-71
- quay.io/devspaces/configbump-rhel8:3.10-12
- quay.io/devspaces/dashboard-rhel8:3.10-12
- quay.io/devspaces/devfileregistry-rhel8:3.10-52
- quay.io/devspaces/devspaces-rhel8-operator:3.10-10
- quay.io/devspaces/idea-rhel8:3.10-4
- quay.io/devspaces/pluginregistry-rhel8:3.10-12
- quay.io/devspaces/server-rhel8:3.10-13
- quay.io/devspaces/traefik-rhel8:3.10-5
- quay.io/devspaces/udi-rhel8:3.10-10
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202309181625.p0.g94f3fde.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202309181625.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4812:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4606 triggered; /job/DS_CI/job/dsc_3.x triggered;

[devstudio-release]

Build 3.10 :: operator-bundle_3.x/2104:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4812 triggered

[devstudio-release]

Build 3.10 :: copyIIBsToQuay/1952: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: dsc_3.x/1423: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: update-digests_3.x/4458:

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/2104 triggered

[devstudio-release]

Build 3.10 :: dsc_3.x/1423:

3.10.0 CI