Do not pass oauth2 as a username to Git credentials for Bitbucket

[vinokurig]

What does this PR do?

Set bitbucket-***** as a token name annotation for bitbucket token secret. This is needed to pass username instead of oauth2 for bitbucket credentials:

che-server/infrastructures/infrastructure-factory/src/main/java/org/eclipse/che/api/factory/server/scm/kubernetes/KubernetesGitCredentialManager.java

Lines 169 to 184 in 7dc7a61

	/**
	* Returns username URL segment for git credentials. For OAuth2 tokens it is "oauth2", for others
	* - {@param personalAccessToken#getScmUserName()} or just "username" string if the token has a
	* non-null {@param personalAccessToken#getScmOrganization()}. This is needed to support providers
	* that do not have username in their user object. Such providers have an additional organization
	* field.
	*/
	private String getUsernameSegment(PersonalAccessToken personalAccessToken) {
	// Special characters are not allowed in URL username segment, so we need to escape them.
	PercentEscaper percentEscaper = new PercentEscaper("", false);
	return personalAccessToken.getScmTokenName().startsWith(OAUTH_2_PREFIX)
	? "oauth2"
	: isNullOrEmpty(personalAccessToken.getScmOrganization())
	? percentEscaper.escape(personalAccessToken.getScmUserName())
	: "username";
	}

This fixes the bug when a private bitbucket.org project is not cloned.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-5952

How to test this PR?

1. Deploy che with the PR image: `quay.io/eclipse/che-server:pr-662
2. Setup bitbucket.org oauth
3. Start a workspace from a private bitbucket.org repository.
   See: the workspace starts successfully.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[ibuziuk]

please, extract the logic to the separate method with a proper javadoc

[ibuziuk]

@vinokurig is the providee name the same for on-prem Bitbucket server and SaaS ?

[vinokurig]

yes, it is the same. We have bitbucket-server implementation but it handles oauth1 only and does not use this logic. OAuth2 flow from both bitbucket and bitbucket server is handled by the bitbucket implementation.

[artaleks9]

/retest

[artaleks9]

/retest

[artaleks9]

Verified on Eclipse Che with quay.io/eclipse/che-server:pr-662 - the functionality works as expected.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment