Code clean up

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
eclipse-che · May 11, 2020 · 4a2985d · 4a2985d
1 parent 4283317
commit 4a2985d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/extensions/eclipse-che-theia-plugin-ext/src/browser/task-config-service.ts b/extensions/eclipse-che-theia-plugin-ext/src/browser/task-config-service.ts
@@ -31,16 +31,10 @@ export class TaskConfigurationsService extends TaskService {
         const source = resolvedTask._source;
         const taskLabel = resolvedTask.label;
 
-        const startResolve = new Date().valueOf();
-
         const terminal = await this.taskTerminalWidgetManager.open(this.getFactoryOptions(resolvedTask), this.getOpenerOptions(resolvedTask));
 
         try {
             const taskInfo = await this.taskServer.run(resolvedTask, this.getContext(), option);
-
-            const finishResolve = new Date().valueOf();
-            console.error('!!!!!  CHE TASK service !!! terminal + run 9-10 ', (finishResolve - startResolve) / 1000);
-
             terminal.start(taskInfo.terminalId);
 
             this.lastTask = { source, taskLabel, scope: resolvedTask._scope };
@@ -76,7 +70,7 @@ export class TaskConfigurationsService extends TaskService {
         const taskConfig = taskInfo ? taskInfo.config : undefined;
         const widget = await this.taskTerminalWidgetManager.open(
             this.getFactoryOptions(taskConfig),
-            this.getOpenerOptions(taskConfig, taskId));
+            this.getOpenerOptions(taskConfig));
 
         widget.start(terminalId);
     }
@@ -100,7 +94,7 @@ export class TaskConfigurationsService extends TaskService {
         };
     }
 
-    protected getOpenerOptions(taskConfig?: TaskConfiguration, taskId?: number): TaskTerminalWidgetOpenerOptions {
+    protected getOpenerOptions(taskConfig?: TaskConfiguration): TaskTerminalWidgetOpenerOptions {
         return {
             widgetOptions: { area: 'bottom' },
             mode: this.getWidgetOpenMode(taskConfig),

diff --git a/plugins/task-plugin/src/task/che-task-runner.ts b/plugins/task-plugin/src/task/che-task-runner.ts
@@ -72,9 +72,6 @@ export class CheTaskRunner {
             };
 
             const execId = await this.machineExecClient.getExecId(machineExec);
-            if (label === 'test') {
-                throw new Error("Che task config must have 'target.containerName' property specified");
-            }
 
             return {
                 taskId: STUB_TASK_ID,