This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Use python:3.7.4-slim as a base image for python #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
requested review from
benoitf,
evidolob,
l0rd,
rhopp and
vparfonov
as code owners
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
@tolusha in the context of this PR it would be nice if you could update the python stack tooling image and it's description. |
41 tasks
|
@l0rd |
l0rd
approved these changes
Sep 10, 2019
dmytro-ndp
pushed a commit
that referenced
this pull request
Sep 11, 2019
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Validate meta.yaml versions to be strings, not numbers Do not allow plugin versions to be specifid in a way that parses as a number. Supporting number alongside string can complicate deserialization implementations, as it's not obvious when a value could be parsed as a number. Examples: - 3.2.1 is a string, but 3.2 requires quotes to parse as a string - Git commit hashes typically contain letters (parse as string) but occasionally will be exclusively digits (parse as number). Signed-off-by: Angel Misevski <amisevsk@redhat.com> * Fix how plugin IDs are computed during the build Fix an issue where computing plugin ids fails if they are strings enclosed in quotation marks Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
It uses Debian based image because Microsoft Python Language Server doesn't start at Alpine based.
What issues does this PR fix or reference?
eclipse-che/che#14074