This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Upgrade vscode-ws-jsonrpc version #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
requested review from
evidolob,
l0rd,
olexii4,
rhopp,
sunix,
vitaliy-guliy and
vparfonov
as code owners
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
benoitf
approved these changes
Oct 4, 2019
olexii4
approved these changes
Oct 6, 2019
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
@RomanNikitenko: here was expected regression eclipse-che/che#14771 |
|
The test was relaunched locally on k8s infra. Test passed without any regressions.: |
musienko-maxim
approved these changes
Oct 7, 2019
|
@musienko-maxim |
23 tasks
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Update vscode-openshift-connector * Remove memory limit from container * Update the latest version to 0.1.5. * Upgrade memory limit to 2G for testing purposes * Update sidecar container ref for proper oc extraction * Adjust memory limit * Update vscode-yaml version to latest, deprecate 0.1.0 version Closes eclipse-che/che#16178 Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade vscode-ws-jsonrpc version
Fixes eclipse-che/che#14724
What issues does this PR fix or reference?
eclipse-che/che#14724
How to test
Run any che task.
You should get pop-up when the task is completed.
Signed-off-by: Roman Nikitenko rnikiten@redhat.com