This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Intercept uri arguments and set container name into file scheme #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
requested review from
evidolob,
azatsarynnyy,
vparfonov,
tolusha and
AndrienkoAleksandr
tolusha
approved these changes
Nov 26, 2019
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
force-pushed
the
vscode-diff
branch
from
21a46c2
to
05b6185
Compare
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
AndrienkoAleksandr
approved these changes
Nov 27, 2019
|
crw-ci-test |
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
|
Was checked locally. There was not any regression. |
musienko-maxim
approved these changes
Nov 27, 2019
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
…562) keep only 3 previous latest releases Change-Id: I4d4681aefd7c0752a55c2d24d16c40ce7933ac58 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Register ArgumentProcessor that is responsible to process only URI argument types. Argument processor checks for the path and if path is not starts with project root, then file scheme modifies with the container name to be looks like this:
file-sidecar-${machineName}. This will allow che-theia to pass into executed commands correct file resources, taken from different containers.Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
eclipse-che/che#13044
Release Notes
Intercept uri arguments and set container name into file scheme
Docs PR
N/A - internal modification.