This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
CRW-537 reorganize dockerfile steps so we can override patch and post-patch steps, such that generated tarball includes patched theia sources #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickboldt
requested review from
benoitf,
evidolob,
l0rd,
rhopp and
vparfonov
as code owners
|
Can one of the admins verify this patch? |
nickboldt
changed the title
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
…on't have to repatch later. move add+apply patch steps to new builder-patch-theia.dockerfile files; add builder-post-patch.dockerfile too move tarball step from builder-clone-theia to builder-post-patch.dockerfile add 'nothing to do on alpine' markers in empty files add same comment in alpine and ubi8 versions of builder-clone-theia.dockerfile Change-Id: I50c9380b5289d91f5ff7542c553c792572047c15 Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
changed the title
benoitf
approved these changes
Dec 3, 2019
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
…erfile Change-Id: Id95ffd9e2c32155e68a0c236d49c148b77c4c2cf Signed-off-by: nickboldt <nboldt@redhat.com>
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
nickboldt
added a commit
to nickboldt/che-theia
that referenced
this pull request
Dec 4, 2019
…-patch steps, such that generated tarball includes patched theia sources (eclipse-che#571) * CRW-537 if patches applied, tar up the results AFTER patching so we don't have to repatch later. move add+apply patch steps to new builder-patch-theia.dockerfile files; add builder-post-patch.dockerfile too move tarball step from builder-clone-theia to builder-post-patch.dockerfile add 'nothing to do on alpine' markers in empty files add same comment in alpine and ubi8 versions of builder-clone-theia.dockerfile Change-Id: I50c9380b5289d91f5ff7542c553c792572047c15 Signed-off-by: nickboldt <nboldt@redhat.com> * add newline to dockerfiles/theia/docker/ubi8/builder-clone-theia.dockerfile Change-Id: Id95ffd9e2c32155e68a0c236d49c148b77c4c2cf Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
added a commit
that referenced
this pull request
Dec 4, 2019
…-patch steps, such that generated tarball includes patched theia sources (#571) (#577) * CRW-537 if patches applied, tar up the results AFTER patching so we don't have to repatch later. move add+apply patch steps to new builder-patch-theia.dockerfile files; add builder-post-patch.dockerfile too move tarball step from builder-clone-theia to builder-post-patch.dockerfile add 'nothing to do on alpine' markers in empty files add same comment in alpine and ubi8 versions of builder-clone-theia.dockerfile Change-Id: I50c9380b5289d91f5ff7542c553c792572047c15 Signed-off-by: nickboldt <nboldt@redhat.com> * add newline to dockerfiles/theia/docker/ubi8/builder-clone-theia.dockerfile Change-Id: Id95ffd9e2c32155e68a0c236d49c148b77c4c2cf Signed-off-by: nickboldt <nboldt@redhat.com>
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
New image has: * Removed wget, used curl instead * Fixed issue with oc missing from the container See eclipse-che/che#17633 Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRW-537 reorganize dockerfile steps so we can override patch and post-patch steps, such that generated tarball includes patched theia sources
Change-Id: I3fdbfb5b46a13f0d3ce616d326181fc6763c3f3b
Signed-off-by: nickboldt nboldt@redhat.com