Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Use the latest version of yeoman-plugin #666

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Use the latest version of yeoman-plugin #666

merged 2 commits into from
Mar 16, 2020

Conversation

vitaliy-guliy
Copy link
Contributor

Signed-off-by: Vitaliy Guliy vgulyy@redhat.com

What does this PR do?

Includes the latest version of @theia/yeoman-plugin to Che-Theia build.

What issues does this PR fix or reference?

eclipse-che/che#16354

@che-bot
Copy link
Contributor

che-bot commented Mar 13, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:666
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:666

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@nickboldt nickboldt mentioned this pull request Mar 13, 2020
Closed
27 tasks
@nickboldt nickboldt self-requested a review March 13, 2020 18:20
nickboldt
nickboldt suggested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the filename defined by THEIA_YEOMAN_PLUGIN versionless so we can seamlessly update it without breaking downstream.

@nickboldt
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Mar 13, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:666
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:666

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:666
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:666

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:666
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:666

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@vitaliy-guliy
Use the latest yeoman-plugin
ef57046 
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:666
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:666

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:666
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:666

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@vitaliy-guliy
Copy link
Contributor Author

crw-ci-test

@vitaliy-guliy vitaliy-guliy mentioned this pull request Mar 16, 2020
Merged
@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:666
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:666

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@nickboldt
Copy link
Contributor

requires additional fix in #670

@nickboldt
Use the latest yeoman-plugin (#668) (part 2)
b61d571 
Change-Id: I43fe01fbc2275b8d32219a54bbc36590af1711f6
Signed-off-by: nickboldt <nboldt@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:666
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:666

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@nickboldt nickboldt mentioned this pull request Mar 16, 2020
Closed
@nickboldt nickboldt merged commit 538111d into master Mar 16, 2020
@vitaliy-guliy
Copy link
Contributor Author

@nickboldt thanks for the fix!

@vitaliy-guliy vitaliy-guliy deleted the update-yeoman-plugin branch March 17, 2020 12:26
@nickboldt
Copy link
Contributor

No problem! I'm just happy to see the happy path tests actually pass sometimes \o/

vinokurig pushed a commit that referenced this pull request Apr 6, 2021
@vitaliy-guliy
Node debug (#666)
58cba2e 
* Introduce ms-vscode/node-debug2/1.42.5

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

* Roll back to previously used quay.io/eclipse/che-sidecar-node tag

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

* Remove older version

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@benoitf benoitf benoitf approved these changes

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@ericwill ericwill Awaiting requested review from ericwill

@vinokurig vinokurig Awaiting requested review from vinokurig

@RomanNikitenko RomanNikitenko Awaiting requested review from RomanNikitenko

@vzhukovs vzhukovs Awaiting requested review from vzhukovs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vitaliy-guliy @che-bot @nickboldt @benoitf @azatsarynnyy