This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
fix(plugin-remote): upstream theia is now requiring EnvVariables #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
azatsarynnyy,
RomanNikitenko and
vzhukovs
as code owners
azatsarynnyy
approved these changes
Mar 20, 2020
|
The same |
|
It's weird but it didn't fix |
Change-Id: Ia6f06ec4591b78e08263330b8c47457d04e3c2ab Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
upstream theia introduce a new required dependency in plugin-ext to EnvVariablesServer
What issues does this PR fix or reference?
Fix eclipse-che/che#16412
Change-Id: Ia6f06ec4591b78e08263330b8c47457d04e3c2ab
Signed-off-by: Florent Benoit fbenoit@redhat.com