Use internal network url for plugin registry. #865

AndrienkoAleksandr · 2020-09-23T20:16:25Z

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

What does this PR do?

Use internal network url for plugin registry.

What issues does this PR fix or reference?

eclipse-che/che#17644

Depends on other pr's:

Yes:
eclipse-che/che-operator#468 and also: eclipse-che/che#17945

Release Notes

Docs PR

none yet...

Happy Path Channel

HAPPY_PATH_CHANNEL=next

che-bot · 2020-09-23T20:49:51Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:865
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:865

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

benoitf · 2020-09-23T21:04:00Z

how does it work when using a custom remote plugin registry url ? For example chectl accept custom registry url

tolusha · 2020-09-24T08:25:08Z

extensions/eclipse-che-theia-plugin-ext/src/node/che-plugin-service.ts

-            if (workspaceSettings && workspaceSettings['cheWorkspacePluginRegistryUrl']) {
-                let uri = workspaceSettings['cheWorkspacePluginRegistryUrl'];
+            if (workspaceSettings && workspaceSettings['cheWorkspacePluginRegistryInternalUrl']) {
+                let uri = workspaceSettings['cheWorkspacePluginRegistryInternalUrl'];


should be fallback to cheWorkspacePluginRegistryUrl if cheWorkspacePluginRegistryInternalUrl isn't set?

Yes, we have fallback on the che-server side. And If user set up external registry, we don't override it to internal link.

If it's handled on the bakend, then we don't need to change the variable name. WDYT?

extensions/eclipse-che-theia-plugin-ext/src/node/che-plugin-service.ts

che-bot · 2020-10-08T23:41:58Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:865
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:865

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

AndrienkoAleksandr · 2020-10-09T10:02:50Z

@benoitf how does it work when using a custom remote plugin registry url ? For example chectl accept custom registry url

I tested, If user set up external registry in the CheCluster object, we don't override it to internal link.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr · 2020-11-25T13:52:48Z

PR rebased.

che-bot · 2020-11-25T14:14:17Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:865
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:865

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

AndrienkoAleksandr · 2020-11-25T22:32:42Z

[crw-ci-test]

AndrienkoAleksandr · 2020-11-25T22:32:53Z

[crw-ci-test --rebuild]

che-bot · 2020-11-25T22:59:18Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:865
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:865

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

AndrienkoAleksandr · 2020-11-26T07:02:24Z

[crw-ci-test --rebuild]

che-bot · 2020-11-26T07:51:34Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:865
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:865

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

azatsarynnyy · 2020-11-26T13:59:56Z

[crw-ci-test]

che-bot · 2020-11-26T14:16:23Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:865
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:865

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

azatsarynnyy · 2020-11-26T14:17:59Z

@AndrienkoAleksandr it's good to merge now

AndrienkoAleksandr · 2020-11-26T14:30:29Z

@azatsarynnyy thanks a lot!

* add plantUML to che-plugins yaml Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com> * fix Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>

AndrienkoAleksandr requested review from azatsarynnyy, benoitf, RomanNikitenko and vzhukovs as code owners September 23, 2020 20:16

tolusha mentioned this pull request Sep 24, 2020

Che Deploy Sprint #190 eclipse-che/che#17800

Closed

48 tasks

tolusha reviewed Sep 24, 2020

View reviewed changes

extensions/eclipse-che-theia-plugin-ext/src/node/che-plugin-service.ts Outdated Show resolved Hide resolved

tolusha mentioned this pull request Oct 1, 2020

Che Deploy Sprint #191 eclipse-che/che#18011

Closed

50 tasks

AndrienkoAleksandr force-pushed the useInternalServiceUrlForPluginRegistry branch 2 times, most recently from 3b444fb to 92c1848 Compare October 8, 2020 23:11

azatsarynnyy approved these changes Oct 9, 2020

View reviewed changes

tolusha mentioned this pull request Oct 26, 2020

Che Deploy Sprint #192 eclipse-che/che#18192

Closed

46 tasks

tolusha mentioned this pull request Nov 16, 2020

Che Deploy Sprint #193 eclipse-che/che#18375

Closed

58 tasks

tolusha approved these changes Nov 25, 2020

View reviewed changes

Use internal network url for plugin registry.

f11d9df

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr force-pushed the useInternalServiceUrlForPluginRegistry branch from 92c1848 to f11d9df Compare November 25, 2020 13:52

AndrienkoAleksandr merged commit ee8eadf into master Nov 26, 2020

AndrienkoAleksandr deleted the useInternalServiceUrlForPluginRegistry branch November 26, 2020 19:41

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

add plantUML to che-plugins yaml (#865)

cc8cbb7

* add plantUML to che-plugins yaml Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com> * fix Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use internal network url for plugin registry. #865

Use internal network url for plugin registry. #865

AndrienkoAleksandr commented Sep 23, 2020 •

edited

Loading

che-bot commented Sep 23, 2020

benoitf commented Sep 23, 2020

tolusha Sep 24, 2020

AndrienkoAleksandr Oct 8, 2020

vitaliy-guliy Nov 25, 2020 •

edited

Loading

che-bot commented Oct 8, 2020

AndrienkoAleksandr commented Oct 9, 2020 •

edited

Loading

AndrienkoAleksandr commented Nov 25, 2020

che-bot commented Nov 25, 2020

AndrienkoAleksandr commented Nov 25, 2020

AndrienkoAleksandr commented Nov 25, 2020

che-bot commented Nov 25, 2020

AndrienkoAleksandr commented Nov 26, 2020

che-bot commented Nov 26, 2020

azatsarynnyy commented Nov 26, 2020

che-bot commented Nov 26, 2020

azatsarynnyy commented Nov 26, 2020

AndrienkoAleksandr commented Nov 26, 2020

Use internal network url for plugin registry. #865

Use internal network url for plugin registry. #865

Conversation

AndrienkoAleksandr commented Sep 23, 2020 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Depends on other pr's:

Release Notes

Docs PR

Happy Path Channel

che-bot commented Sep 23, 2020

benoitf commented Sep 23, 2020

tolusha Sep 24, 2020

Choose a reason for hiding this comment

AndrienkoAleksandr Oct 8, 2020

Choose a reason for hiding this comment

vitaliy-guliy Nov 25, 2020 • edited Loading

Choose a reason for hiding this comment

che-bot commented Oct 8, 2020

AndrienkoAleksandr commented Oct 9, 2020 • edited Loading

AndrienkoAleksandr commented Nov 25, 2020

che-bot commented Nov 25, 2020

AndrienkoAleksandr commented Nov 25, 2020

AndrienkoAleksandr commented Nov 25, 2020

che-bot commented Nov 25, 2020

AndrienkoAleksandr commented Nov 26, 2020

che-bot commented Nov 26, 2020

azatsarynnyy commented Nov 26, 2020

che-bot commented Nov 26, 2020

azatsarynnyy commented Nov 26, 2020

AndrienkoAleksandr commented Nov 26, 2020

AndrienkoAleksandr commented Sep 23, 2020 •

edited

Loading

vitaliy-guliy Nov 25, 2020 •

edited

Loading

AndrienkoAleksandr commented Oct 9, 2020 •

edited

Loading