Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Disable tasks output scanning for the imported Che commands #889

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Oct 21, 2020

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Disables tasks output scanning for the imported Che commands.

For the user, it means that they don't have to choose Continue without scanning the task output each time when running a task, so they won't see this list at all:
image

By default, all Che tasks will have an empty problem matcher ("problemMatcher": []). It can be configured optionally.

What issues does this PR fix or reference?

closes eclipse-che/che#17970

Release Notes

Docs PR

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Copy link
Member Author

[crw-ci-test]

@azatsarynnyy
Copy link
Member Author

[crw-ci-test]

@eclipse-che eclipse-che deleted a comment from che-bot Oct 22, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Oct 22, 2020
@azatsarynnyy azatsarynnyy marked this pull request as ready for review October 22, 2020 10:09
@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:889
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:889

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@eclipse-che eclipse-che deleted a comment from che-bot Oct 22, 2020
@rhopp
Copy link
Contributor

rhopp commented Oct 22, 2020

I've changes the Happy Path & built the e2e test image locally with the change. Then I created copy of the PR check job to run with the test image with changes.
If that succeeds, I'll create PR with my test changes to che repo, this PR could be merged and my PR with test changes could be merged just afterwards.

@eclipse-che eclipse-che deleted a comment from che-bot Oct 22, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Oct 22, 2020
rhopp added a commit to eclipse-che/che that referenced this pull request Oct 22, 2020
This change is needed to reflec change done in eclipse-che/che-theia#889

Signed-off-by: Radim Hopp <rhopp@redhat.com>
@eclipse-che eclipse-che deleted a comment from che-bot Oct 22, 2020
@rhopp
Copy link
Contributor

rhopp commented Oct 22, 2020

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Oct 22, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:889
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:889

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@rhopp
Copy link
Contributor

rhopp commented Oct 22, 2020

@azatsarynnyy Happy Path with my changes succeeded. Feel free to merge this PR (ping me on slack once you do that pls).
Then I'll wait for new che-theia image to be built and I'll merge the Happy Path fix in eclipse/che then. This should be the path of least resistance.

@azatsarynnyy
Copy link
Member Author

Okay, merging...
Thanks a lot @rhopp !

@azatsarynnyy azatsarynnyy merged commit 07c7db3 into master Oct 22, 2020
@azatsarynnyy azatsarynnyy deleted the emptyProblemMatcher branch October 22, 2020 13:02
rhopp added a commit to eclipse-che/che that referenced this pull request Oct 22, 2020
This change is needed to reflec change done in eclipse-che/che-theia#889

Signed-off-by: Radim Hopp <rhopp@redhat.com>
rhopp added a commit to rhopp/che-tests-playground that referenced this pull request Apr 16, 2021
This change is needed to reflec change done in eclipse-che/che-theia#889

Signed-off-by: Radim Hopp <rhopp@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable tasks output scanning
4 participants