Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Use CHE_API_EXTERNAL for OauthUtils #953

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Use CHE_API_EXTERNAL for OauthUtils #953

merged 1 commit into from
Dec 15, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 15, 2020

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Use CHE_API_EXTERNAL for OauthUtils

Screenshot/screencast of this PR

Screenshot from 2020-12-15 12-36-22

What issues does this PR fix or reference?

PullRequest plugin doesn't work

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@che-bot
Copy link
Contributor

che-bot commented Dec 15, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:953
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:953

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@tolusha
Copy link
Contributor Author

tolusha commented Dec 15, 2020

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Dec 15, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:953
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:953

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@azatsarynnyy
Copy link
Member

@tolusha rebase it on master branch to include a recent fix #952

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Dec 15, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:953
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:953

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that I'm able to sing into GitHub with these changes applied
image
Thanks!

@tolusha
Copy link
Contributor Author

tolusha commented Dec 15, 2020

How I can rerun ci.centos. job ?

@azatsarynnyy
Copy link
Member

How I can rerun ci.centos. job ?

@tolusha don't care about it as it's unstable and we have several GitHub Actions based jobs instead. Everything is fine. Please merge.

@tolusha tolusha merged commit bbe4fe1 into master Dec 15, 2020
@tolusha tolusha deleted the fixpullrequestplugin branch December 15, 2020 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants